ASP string manipulation

[Jezza]

I am creating a classic ASP that will output form inputs to an XML file and one requirement for auditing purposes is to have the NT user name added, I am using the code below to obtain that but it comes out in the form of myDomain\JBear however I would like it to come out as JBear.

Code: Select all

{
	// Function to get user name currently logged into Workbench so their details can
	//be added to the XML output
  
	var strUser =Request.ServerVariables("LOGON_USER");
	
}

I have tried string manipulation but all I get is as error shown below where line 25 is the location of the string function:

Code: Select all

Microsoft JScript runtime error '800a138f' 

Object expected 

/workbook/workbench.asp, line 25 

I would have added something like:

Code: Select all

var strUser=substring(strUser,9);

Any ideas?

[HansV]

Try this:

Code: Select all

{
   // Function to get user name currently logged into Workbench so their details can
   //be added to the XML output
  
   var strUser=Request.ServerVariables('LOGON_USER');
   var p=strUser.indexOf('\');
   strUser=strUser.substr(p+1);

}

In this example, substr and substring have the same result: if you omit the second argument, the entire substring starting at the position specified by the first argument is returned.

[Jezza]

Thanks Hans, that makes sense but now I get:

Code: Select all

Microsoft JScript compilation error '800a03f7' 

Unterminated string constant 

/workbook/Workbench.asp, line 25 

var p=strUser.indexOf("\");
---------------------------^

So I changed it to

Code: Select all

var strUser =Request.ServerVariables("LOGON_USER");
	//var p=strUser.indexOf('\');
    strUser=strUser.substring(11);

and now get:

Code: Select all

Microsoft JScript runtime error '800a01b6' 

Object doesn't support this property or method 

/workbook/Workbench.asp, line 26 

Weird

[HansV]

He he - \ is a special character in strings, so you have to escape it with another \. So try

Code: Select all

{
   // Function to get user name currently logged into Workbench so their details can
   //be added to the XML output
  
   var strUser=Request.ServerVariables('LOGON_USER');
   var p=strUser.indexOf('\\');
   strUser=strUser.substr(p+1);

}

[Jezza]

:-) I tried that in the interim period but I get

Object doesn't support this property or method

Interesting enough though as soon as I change strUser to "1234\ABCD" it does allow it but returns 1234ABCD so it must be the way it sees Request.ServerVariables("LOGON_USER")

[HansV]

I'm afraid I'm out of my depth here. Sorry!

[Jezza]

Deleted content by Jezza as I got a bit clumsy and reposted in corect format!!!

[Jezza]

No problems at all, thanks for your help

Just to say where I have got so far:

If I use:

Code: Select all

var strUser = "myDomain\JBear"; //Request.ServerVariables("LOGON_USER"); 
var p=strUser.indexOf('\\');
strUser=strUser.substr(p+1);

It returns JBear

It just does not seem to like Request.ServerVariables("LOGON_USER"); becuase if you write the value p it returns -1 which is where it fails..maddening

[Jezza]

....and just to put closure on it, I forced the Request.ServerVariables("LOGON_USER"); to be treated as a string by adding _space_ to the end and it works fine

Code: Select all

// Function to get user name currently logged into Workbench so their details can
	//be added to the XML output
	
	var strLogOn= Request.ServerVariables("LOGON_USER");
	
	strUser = strLogOn + " ";
	
	var p=strUser.indexOf('\\');
    strUser=strUser.substr(p+1);
	//Response.Write(strUser);

[HansV]

Ah - so Request.ServerVariables("LOGON_USER") is probably an object, and by adding a space you force JavaScript to use its default property - the name...