logic if end if..

[sal21]

If Mid$(TEST, 1, 2) = "OP" And EROGATI > 0 Or INTROITATI And Not EROGA = "OK" And Not INTROI = "OK" Then

end if

i need to exclude EROGATI and INTROITATI if the condition EROGA and INTROI is "OK" and "viceversa" is correct?

[HansV]

I don't really understand what you're asking, so this is a general reply.

And has precedence above Or, so your condition can be read as

If (Mid$(TEST, 1, 2) = "OP" And EROGATI > 0) Or (INTROITATI And Not EROGA = "OK" And Not INTROI = "OK") Then

If you want something different, you can use parentheses ( ) to force a different interpretation, for example

If Mid$(TEST, 1, 2) = "OP" And (EROGATI > 0 Or INTROITATI) And Not EROGA = "OK" And Not INTROI = "OK" Then

[sal21]

I don't really understand what you're asking, so this is a general reply.

And has precedence above Or, so your condition can be read as

If (Mid$(TEST, 1, 2) = "OP" And EROGATI > 0) Or (INTROITATI And Not EROGA = "OK" And Not INTROI = "OK") Then

If you want something different, you can use parentheses ( ) to force a different interpretation, for example

If Mid$(TEST, 1, 2) = "OP" And (EROGATI > 0 Or INTROITATI) And Not = "OK" And Not INTROI = "OK" Then

in effect i need to use only one pair of condition or the first pair ( EROGATI and INTROITATI)or the second pair ( EROGA and INTROI) when Mid$(TEST, 1, 2) = "OP" is true...

[HansV]

Please explain very precisely what the conditions for each should be.

[agibsonsw]

I don't follow either, but I have a couple of suggestions that might help:

Put the most significant test first - this helps to break down the statement;
Introduce boolean variables - this will make it easier to test, and easier to create your test condition(s):

Code: Select all

    Dim blnOk As Boolean
    'EROGA = "OK"
    'INTROI = "OK"
    blnOk = EROGA = "OK" Or INTROI = "OK"
    Debug.Print blnOk

Use brackets (Hans );
Try to write the conditions in a way that reduces the use of 'Not'. 'Not' is harder to follow/ keep track of when reading the statement.

Andy.

[macropod]

Hi Sal,

Something the others haven't mentioned is that having all those tests in a single statement is very inefficient, as VBA has to test all of them before being able to move on. A more efficient construct (without commenting on whether it does what you want), would be something like:

Code: Select all

If Mid$(TEST, 1, 2) = "OP" Then
  If EROGATI > 0 Or INTROITATI Then
    If EROGA <> "OK" And INTROI <> "OK" Then
      'Do something
    End If
  End If
End If