Standards & Practices - Better use of MsgBox

[ChrisGreaves]

I must be fairly new to this VBA stuff; don't know why I didn't adopt this practice before ...

I am wading thorough acres hectares of code replacing
MsgBox "You don't appear to have any words interesting enough to index!"
with
MsgBox "IndexActiveDocument- You don't appear to have any words interesting enough to index!"

That is, including the name of the procedure with every MsgBox (or my custom logging procedure) call.

I am motivated by an error report from a user who says "I got just an empty pop-up message box".
I don't know whether the MsgBox was mine or not, but from now on, I'll know if it WAS one of mine; also I'll get some idea of what the user might have been attempting.

[agibsonsw]

You could add the name of the procedure to the Title - this might be less confusing for the user.

[ChrisGreaves]

You could add the name of the procedure to the Title - this might be less confusing for the user.

Thanks Andy!

Like I said I must be fairly new to this VBA stuff;

[StuartR]

I have a variable strMsgTitle that I set to the name of the procedure at the start of each Sub or Function and use as the title of all message boxes.

[agibsonsw]

I understand there is no straight-forward way to get the name of the currently running procedure. This is a shame as it would make the coding of the MsgBox, for every procedure, easier.

This page http://www.cpearson.com/excel/InsertProcedureNames.aspx provides code to achieve this, but it's probably only worth using if there are lots of procedures involved. Still, an interesting piece of code

[JohnH]

When I add an error handler using MZ Tools it adds the name of the procedure and the current form name automatically.

Code: Select all

 MsgBox "Error " & Err.Number & " (" & Err.Description & ") in procedure sbtest of VBA Document Form_frmMainMenu" 

But when I then copy and paste the procedure into a different context I have to remember to change it.

ErrorHandler.gif

[ChrisGreaves]

This page http://www.cpearson.com/excel/InsertProcedureNames.aspx provides code to achieve this,

And a beautiful piece of code it is, too.
I wonder hy he disallows lower-case letters in identifiers.

Code: Select all

strcProcName

[HansV]

I wonder hy he disallows lower-case letters in identifiers.

Code: Select all

strcProcName

Sorry, I don't understand your remark.

[ChrisGreaves]

"strcProcName" Sorry, I don't understand your remark.

Hi Hans.
I emailed Chip and he promptly (no kidding!) emailed back.
There is an "Option Compare Text" directive which I've not used before.
I am currently essaying in Word2003 & Excel2003 to see why my system still baulks on lower-case letters.