why open report based on filter not working

[siamandm]

Hello All,

i have a report which it's data source is a select query
and I have a form with a combo box the data source is a table employee, I have chosen id and employeename

there is a button with a vba code in the on click event like below :
but it always bring the first employee and ignore the combo box selection

Code: Select all

Private Sub cmdPrtRpt_Click()
        
        
                Dim strWhere As String
                        
                If Not IsNull(Me.cboEmployeeFullName) Then
                stWhere = EmployeeFullName = Me.cboEmployeeFullName.Column(1)
                End If
                
        DoCmd.OpenReport REPORTNAME:="rptEmployee", view:=acViewReport, WhereCondition:=strWhere

End Sub

[HansV]

The where-condition must be a string:

Code: Select all

                stWhere = "EmployeeFullName = '" & Me.cboEmployeeFullName.Column(1) & "'"

[siamandm]

thank you very much for the quick reply,
still didn't work, I believe I have missed something in the report or in the query,
I have a simple select query without any criteria, and the report which gets data from it also does not have any criteria
any suggestions, please?

regards

[HansV]

Me.cboEmployeeFullName.Column(1) is the second column of the combo box. What is in that column?

[siamandm]

its employee full name
kindly see the attached database,
the form frmReport is the one which I want to use and rptEmployee ,

Regards

[HansV]

It's a typo: you use stWhere instead of strWhere.
This could have been avoided if you had had Option Explicit at the top of the module.

Code: Select all

Private Sub cmdPrtRpt_Click()
    Dim strWhere As String
    If Not IsNull(Me.cboEmployeeFullName) Then
        strWhere = "EmpID = " & Me.cboEmployeeFullName
    End If
    DoCmd.OpenReport ReportName:="rptEmployee", View:=acViewReport, WhereCondition:=strWhere
End Sub

[siamandm]

thank you very much for your correction,

how to have Option Explicit at the top of the module, please?

Regards

[StuartR]

how to have Option Explicit at the top of the module, please?

You literally type
Option Exliciit
on a line by itself as the very first line in the module, before any other content.

[HansV]

Also see The importance of 'Option Explicit'

[siamandm]

thank you very much for the informative link